Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Add HLS interstitial support #6761

Merged
merged 20 commits into from
Jun 7, 2024
Merged

feat(HLS): Add HLS interstitial support #6761

merged 20 commits into from
Jun 7, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 5, 2024

Closes #3364

@avelad avelad marked this pull request as draft June 5, 2024 15:19
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Jun 5, 2024
@avelad avelad added this to the v4.10 milestone Jun 5, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 5, 2024 •
edited
Loading

Incremental code coverage: 82.38%

@avelad
Copy link
Member Author

avelad commented Jun 6, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6761

@avelad avelad marked this pull request as ready for review June 7, 2024 08:41
@avelad avelad requested review from joeyparrish and theodab June 7, 2024 08:46
theodab
theodab requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent a while reading over this, and did some manual testing.
Overall, it looks pretty good. I just have a few comments.

@avelad avelad merged commit 60e6847 into shaka-project:main Jun 7, 2024
28 of 30 checks passed
@shaka-bot shaka-bot mentioned this pull request Jun 7, 2024
Merged
@avelad avelad deleted the hls-interstitial branch June 7, 2024 14:24
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.

HLS interstitial support
3 participants
@avelad @shaka-bot @theodab