Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude fetch polyfill from fetch plugin #6838

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 17, 2024

This fix excludes the use of https://www.npmjs.com/package/fetch-polyfill because it does not support a signal to cancel requests in progress.

@avelad avelad requested review from joeyparrish and theodab June 17, 2024 07:55
@avelad avelad added type: bug Something isn't working correctly component: networking The issue involves the networking system of Shaka Player labels Jun 17, 2024
@avelad avelad added this to the v4.10 milestone Jun 17, 2024
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jun 17, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 8bb2d6e into shaka-project:main Jun 17, 2024
19 of 20 checks passed
@avelad avelad deleted the fetch-polyfill branch June 17, 2024 10:33
avelad added a commit that referenced this pull request Jun 18, 2024
This fix excludes the use of
https://www.npmjs.com/package/fetch-polyfill because it does not support
a signal to cancel requests in progress.
avelad added a commit that referenced this pull request Jun 18, 2024
This fix excludes the use of
https://www.npmjs.com/package/fetch-polyfill because it does not support
a signal to cancel requests in progress.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 16, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: networking The issue involves the networking system of Shaka Player priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants