Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Fix get basic info from segments #6898

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 24, 2024

Allows you to obtain the correct segment to detect the basic information of the stream (middle segment for Live, and the first segment for VoD).
Avoid obtaining information from segments that are gaps.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jun 24, 2024
@avelad avelad added this to the v4.10 milestone Jun 24, 2024
@avelad avelad requested a review from theodab June 24, 2024 12:57
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 98.56%

@avelad avelad added the component: HLS The issue involves Apple's HLS manifest format label Jun 24, 2024
@avelad avelad merged commit 02331e1 into shaka-project:main Jun 25, 2024
18 of 19 checks passed
@avelad avelad deleted the hls-basic-info branch June 25, 2024 07:03
avelad added a commit that referenced this pull request Jun 26, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 24, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants