Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow set the videoContainer in the Player constructor #6953

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: Allow set the videoContainer in the Player constructor #6953

merged 1 commit into from
Jul 8, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 1, 2024

Related to #6672 (comment)

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Jul 1, 2024
@avelad avelad added this to the v4.11 milestone Jul 1, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@littlespex littlespex requested a review from joeyparrish July 2, 2024 18:33
theodab
theodab approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, it doesn't look like there's any good places to use this new feature in our codebase itself.
Well, if it's useful to the users, anyway...

@avelad avelad merged commit a35028c into shaka-project:main Jul 8, 2024
21 of 22 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 8, 2024
Merged
@avelad avelad deleted the videocontainer-constructor branch July 8, 2024 07:12
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@alekzz alekzz Awaiting requested review from alekzz

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab