Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(HLS): do not loop twice when processing nalus #6954

Conversation

vanyaxk
Copy link
Contributor

@vanyaxk vanyaxk commented Jul 1, 2024

PES arrays can get pretty big so it would be prudent to avoid looping over them more than needed

Copy link

google-cla bot commented Jul 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vanyaxk vanyaxk force-pushed the perf/do-not-loop-twice-when-processing-nalus branch from 252846a to 66b1f33 Compare July 1, 2024 11:03
@avelad avelad added type: performance A performance issue priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 1, 2024
@avelad avelad added this to the v4.11 milestone Jul 1, 2024
@avelad avelad self-requested a review July 1, 2024 11:04
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit a779d31 into shaka-project:main Jul 1, 2024
17 of 18 checks passed
avelad pushed a commit that referenced this pull request Jul 2, 2024
PES arrays can get pretty big so it would be prudent to avoid looping
over them more than needed

Co-authored-by: Ivan Kohut <[email protected]>
avelad pushed a commit that referenced this pull request Jul 2, 2024
PES arrays can get pretty big so it would be prudent to avoid looping
over them more than needed

Co-authored-by: Ivan Kohut <[email protected]>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 30, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: performance A performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants