Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ads): Fix mangled properties when using X-ASSET-LIST #7002

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(Ads): Fix mangled properties when using X-ASSET-LIST #7002

merged 2 commits into from
Jul 8, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 8, 2024

No description provided.

@avelad avelad requested a review from theodab July 8, 2024 13:45
@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 8, 2024
@avelad avelad added this to the v4.11 milestone Jul 8, 2024
@avelad
Merge branch 'main' into mangled-asset-list
5497d8c 
# Conflicts:
#	lib/ads/interstitial_ad_manager.js
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

@avelad avelad merged commit ade19cb into shaka-project:main Jul 8, 2024
8 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 8, 2024
Merged
@avelad avelad deleted the mangled-asset-list branch July 9, 2024 06:34
avelad added a commit that referenced this pull request Jul 10, 2024
@avelad
fix(Ads): Fix mangled properties when using X-ASSET-LIST (#7002)
e42fd3f
@shaka-bot shaka-bot mentioned this pull request Jul 10, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab