Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid reset iterator when seek into the buffer #7004

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 8, 2024

When using HLS LL and making seek small this produces overlaps

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 8, 2024
@avelad avelad added this to the v4.11 milestone Jul 8, 2024
@avelad avelad requested a review from theodab July 8, 2024 15:21
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

@avelad avelad merged commit dc34ec4 into shaka-project:main Jul 9, 2024
12 of 19 checks passed
@avelad avelad deleted the seeked-streaming-engine branch July 9, 2024 08:38
avelad added a commit that referenced this pull request Jul 10, 2024
When using HLS LL and making seek small this produces overlaps
avelad added a commit that referenced this pull request Jul 10, 2024
When using HLS LL and making seek small this produces overlaps
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 7, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants