Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ttml): Handle escaped special characters. #7047

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

theodab
Copy link
Contributor

@theodab theodab commented Jul 16, 2024

Fixes #7044

@theodab theodab added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically labels Jul 16, 2024
@avelad avelad self-requested a review July 16, 2024 07:46
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Jul 16, 2024
@avelad avelad added this to the v4.11 milestone Jul 16, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 94.44%

@avelad avelad merged commit 90668c2 into shaka-project:main Jul 16, 2024
8 of 15 checks passed
@theodab theodab deleted the specialCharactersBranch branch July 16, 2024 08:46
avelad pushed a commit that referenced this pull request Jul 18, 2024
avelad pushed a commit that referenced this pull request Jul 18, 2024
avelad pushed a commit that referenced this pull request Jul 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.10.7](v4.10.6...v4.10.7)
(2024-07-18)


### Bug Fixes

* Allow reference mimeType change in StreamingEngine
([#7061](#7061))
([2fe4dcc](2fe4dcc))
* **DASH:** Prioritize highest bandwidth in PeriodCombiner
([#7045](#7045))
([30cdd61](30cdd61))
* Destroy correctly unused transmuxer
([#7059](#7059))
([7641475](7641475))
* Fix MSE polyfill for iOS
([#7049](#7049))
([44dc9a9](44dc9a9))
* **HLS:** Remove init segment on formats without init segment
([#7060](#7060))
([ee179ad](ee179ad))
* **Transmuxer:** Fix init segment between discontinuities
([#7042](#7042))
([dd2a6d7](dd2a6d7))
* **ttml:** Handle escaped special characters.
([#7047](#7047))
([451a41e](451a41e)),
closes
[#7044](#7044)
* **UI:** Fix resolution label when the stream has not resolution
([#7043](#7043))
([9e468f4](9e468f4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 14, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
3 participants