Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only check encryptionScheme when is not null and not empty string #7079

Merged
merged 1 commit into from
Jul 20, 2024
Merged

fix: Only check encryptionScheme when is not null and not empty string #7079

merged 1 commit into from
Jul 20, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 19, 2024

Fixes #7057

@avelad
Copy link
Member Author

avelad commented Jul 19, 2024

According to https://w3c.github.io/encrypted-media/:

imagen

null is the default value
empty string whould be treated as an unrecogniezed encryption scheme, in our case we assume that any encryption scheme would be valid.

@avelad avelad requested a review from theodab July 19, 2024 14:13
@avelad avelad added type: bug Something isn't working correctly component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 19, 2024
@avelad avelad added this to the v4.11 milestone Jul 19, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit c62c5b5 into shaka-project:main Jul 20, 2024
16 of 19 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 20, 2024
Merged
@avelad avelad deleted the fix-encryptionScheme branch July 22, 2024 06:31
avelad added a commit that referenced this pull request Jul 22, 2024
@avelad
fix: Only check encryptionScheme when is not null and not empty string (
6c0718c 
#7079)

Fixes #7057
@shaka-bot shaka-bot mentioned this pull request Jul 22, 2024
Merged
avelad added a commit that referenced this pull request Jul 22, 2024
@avelad
fix: Only check encryptionScheme when is not null and not empty string (
bcbcbe8 
#7079)

Fixes #7057
@shaka-bot shaka-bot mentioned this pull request Jul 22, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 18, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.

Error with Shaka Player on Firefox: DRM.REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLE
3 participants
@avelad @shaka-bot @theodab