Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix playback of preroll interstitial when the currentTime is 0 #7092

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 23, 2024

No description provided.

@avelad avelad requested a review from theodab July 23, 2024 13:36
@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 23, 2024
@avelad avelad added this to the v4.11 milestone Jul 23, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad force-pushed the interstitial-preroll branch from a594b45 to b80683a Compare July 23, 2024 15:34
@avelad avelad merged commit 0cdeb65 into shaka-project:main Jul 24, 2024
12 of 15 checks passed
@avelad avelad deleted the interstitial-preroll branch July 24, 2024 06:22
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants