Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ads): Detect correctly interstitial preroll when using native HLS playback in Safari #7093

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix(Ads): Detect correctly interstitial preroll when using native HLS playback in Safari #7093

merged 1 commit into from
Jul 24, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 23, 2024

No description provided.

@avelad avelad changed the title fix(Ads): Detect correctly interstitial preroll when using Safari fix(Ads): Detect correctly interstitial preroll when using native HLS playback in Safari Jul 23, 2024
@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jul 23, 2024
@avelad avelad requested a review from theodab July 23, 2024 14:27
@avelad avelad added this to the v4.11 milestone Jul 23, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

@avelad avelad merged commit 9912798 into shaka-project:main Jul 24, 2024
17 of 20 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 23, 2024
Merged
@avelad avelad deleted the safari-preroll branch July 24, 2024 06:23
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab