Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Clear streamMap when period is removed from the manifest #7297

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(DASH): Clear streamMap when period is removed from the manifest #7297

merged 1 commit into from
Sep 13, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 12, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Sep 12, 2024
@avelad avelad requested a review from tykus160 September 12, 2024 15:45
@avelad avelad added this to the v4.12 milestone Sep 12, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit da71e6d into shaka-project:main Sep 13, 2024
18 of 19 checks passed
@avelad avelad deleted the dash-clear-streamMap branch September 13, 2024 08:38
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@avelad @joeyparrish
fix(DASH): Clear streamMap when period is removed from the manifest (#…
edc08bd 
…7297)
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@avelad @joeyparrish
fix(DASH): Clear streamMap when period is removed from the manifest (#…
71a8414 
…7297)
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@avelad @joeyparrish
fix(DASH): Clear streamMap when period is removed from the manifest (#…
81c2450 
…7297)
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
@Iragne
Copy link
Contributor

Iragne commented Oct 8, 2024

May i ask you why we remove this condition ?
I'm not able to understand why we remove that optimization

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 12, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.
4 participants
@avelad @shaka-bot @Iragne @tykus160