Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not seek to first subtitle #7312

Merged

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Sep 13, 2024

The bug was introduced in #6340, and affects v4.6.16-18, v4.7.12-15, v4.8.0-20, v4.9.0-26, v4.10.0-16, and v4.11.0-2.

Closes #7310

The bug was introduced in shaka-project#6340, and affects v4.6.16-18, v4.7.12-15,
v4.8.0-20, v4.9.0-26, v4.10.0-16, and v4.11.0.

Closes shaka-project#7310
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@joeyparrish joeyparrish merged commit 0980ba3 into shaka-project:main Sep 13, 2024
19 of 20 checks passed
@joeyparrish joeyparrish deleted the fix-seeking-over-text-gaps branch September 13, 2024 18:25
joeyparrish added a commit that referenced this pull request Sep 13, 2024
The bug was introduced in #6340, and affects v4.6.16-18, v4.7.12-15,
v4.8.0-20, v4.9.0-26, v4.10.0-16, and v4.11.0.

Closes #7310
joeyparrish added a commit that referenced this pull request Sep 13, 2024
The bug was introduced in #6340, and affects v4.6.16-18, v4.7.12-15,
v4.8.0-20, v4.9.0-26, v4.10.0-16, and v4.11.0.

Closes #7310
joeyparrish added a commit that referenced this pull request Sep 13, 2024
The bug was introduced in #6340, and affects v4.6.16-18, v4.7.12-15,
v4.8.0-20, v4.9.0-26, v4.10.0-16, and v4.11.0.

Closes #7310
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 12, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Seek over gap" feature seeks to first subtitle when subs are enabled
3 participants