Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dash): live to vod transition seek start #7347

Merged

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Sep 20, 2024

Fixes #7346

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad
Copy link
Member

avelad commented Sep 23, 2024

I think the change could be good, but I need to test it with several streams from different providers.

@avelad avelad self-requested a review September 23, 2024 05:31
@avelad avelad added type: bug Something isn't working correctly component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround labels Sep 23, 2024
@avelad avelad added this to the v4.12 milestone Sep 23, 2024
@avelad
Copy link
Member

avelad commented Sep 23, 2024

I have tested it with livesim2 and with ATEME streams and it works correctly

@avelad avelad merged commit e02367c into shaka-project:main Sep 23, 2024
15 of 16 checks passed
avelad added a commit that referenced this pull request Sep 24, 2024
Fixes #7346

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad added a commit that referenced this pull request Sep 24, 2024
Fixes #7346

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
joeyparrish pushed a commit that referenced this pull request Sep 26, 2024
Fixes #7346

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash Live 2 vod transition seekRange start wrong and timeline broken
3 participants