Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable Encryption Scheme Polyfil On Some Devices #7355

Merged

Conversation

agajassi
Copy link
Contributor

@agajassi agajassi commented Sep 23, 2024

Fixes #7354
These platforms don't support encryptionScheme, so there is no need to install this polyfil.

added another platform for SkyQ set top box
To avoid crashes, don't install this polyfil on these 2 devices
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 88.89%

@avelad avelad added type: bug Something isn't working correctly platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P1 Big impact or workaround impractical; resolve before feature release platform: Playstation 4 Issues affecting Playstation 4 labels Sep 23, 2024
@avelad avelad added this to the v4.12 milestone Sep 23, 2024
@avelad avelad merged commit 58f666b into shaka-project:main Sep 24, 2024
23 of 24 checks passed
avelad pushed a commit that referenced this pull request Sep 24, 2024
Fixes #7354
These platforms don't support `encryptionScheme`, so there is no need to
install this polyfil.
avelad pushed a commit that referenced this pull request Sep 24, 2024
Fixes #7354
These platforms don't support `encryptionScheme`, so there is no need to
install this polyfil.
joeyparrish pushed a commit that referenced this pull request Sep 26, 2024
Fixes #7354
These platforms don't support `encryptionScheme`, so there is no need to
install this polyfil.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 23, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Playstation 4 Issues affecting Playstation 4 platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video Start Failure and Application Crash On Some Platforms
4 participants