Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce calls to EME by ignoring MIME type in MediaKeySystemAccess cache #7374

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: Reduce calls to EME by ignoring MIME type in MediaKeySystemAccess cache #7374

merged 1 commit into from
Sep 26, 2024

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Sep 25, 2024 •
edited by avelad
Loading

Fixes #7325

@tykus160
Copy link
Member Author

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=7374

@tykus160
Copy link
Member Author

@massicottem can you try to test your stream against this PR?

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Sep 25, 2024
@avelad avelad added this to the v4.12 milestone Sep 25, 2024
@massicottem
Copy link
Contributor

Wonderful, the fix seems to work!

@tykus160 tykus160 marked this pull request as ready for review September 26, 2024 05:17
@joeyparrish joeyparrish changed the title fix: Cache MediaKeySystemAccess objects with codec bases fix: Reduce calls to EME by ignoring MIME type in MediaKeySystemAccess cache Sep 26, 2024
@joeyparrish joeyparrish merged commit 6a4e95b into shaka-project:main Sep 26, 2024
51 of 54 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 26, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 26, 2024
@tykus160 @joeyparrish
fix: Reduce calls to EME by ignoring MIME type in MediaKeySystemAcces…
bbcc8c9 
…s cache (#7374)

Fixes #7325
@shaka-bot shaka-bot mentioned this pull request Sep 26, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 26, 2024
@tykus160 @joeyparrish
fix: Reduce calls to EME by ignoring MIME type in MediaKeySystemAcces…
2047aa4 
…s cache (#7374)

Fixes #7325
@shaka-bot shaka-bot mentioned this pull request Sep 26, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 26, 2024
@tykus160 @joeyparrish
fix: Reduce calls to EME by ignoring MIME type in MediaKeySystemAcces…
d37e0ed 
…s cache (#7374)

Fixes #7325
@shaka-bot shaka-bot mentioned this pull request Sep 26, 2024
Merged
@tykus160 tykus160 deleted the wt-ps5-drm branch October 11, 2024 08:26
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 25, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@massicottem massicottem massicottem approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.

Video quality degradation when loading a manifest with multiple video/audio tracks on PlayStation 5
5 participants
@tykus160 @shaka-bot @massicottem @joeyparrish @avelad