Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'downloadcompleted' event #7609

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat: Add 'downloadcompleted' event #7609

merged 1 commit into from
Nov 18, 2024

Conversation

vlazh
Copy link
Contributor

@vlazh vlazh commented Nov 15, 2024

Closes #7608

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: networking The issue involves the networking system of Shaka Player labels Nov 15, 2024
@avelad avelad added this to the v4.13 milestone Nov 15, 2024
@vlazh vlazh force-pushed the patch-1 branch 2 times, most recently from 53205a7 to da8d818 Compare November 15, 2024 16:53
tykus160
tykus160 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@tykus160 tykus160 merged commit 13186bd into shaka-project:main Nov 18, 2024
17 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 18, 2024
Merged
@tykus160 tykus160 mentioned this pull request Nov 18, 2024
Merged
avelad pushed a commit that referenced this pull request Nov 18, 2024
@tykus160
feat: Add downloadcompleted event description (#7615)
0db5813 
Missing piece of #7609
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 17, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@avelad avelad Awaiting requested review from avelad

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: networking The issue involves the networking system of Shaka Player priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

feat: Add 'downloadcompleted' event
4 participants
@vlazh @tykus160 @avelad @shaka-bot