Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix usage of ENABLE-SKIP-AFTER and ENABLE-SKIP-FOR #7677

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 27, 2024

No description provided.

@avelad avelad requested a review from tykus160 November 27, 2024 10:17
@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Nov 27, 2024
@avelad avelad added this to the v4.13 milestone Nov 27, 2024
@avelad avelad merged commit 8048d02 into shaka-project:main Nov 27, 2024
17 of 21 checks passed
@avelad avelad deleted the skip-ads branch November 27, 2024 10:55
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 26, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants