Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Omit daterange without START-DATE in order to avoid errors #7841

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 8, 2025

Per the HLS spec, we require a START-DATE for SCTE35-IN
However, unlike for SCTE35-OUT and SCTE35-CMD, it’s not clear what that value should be – and the HLS spec example does not include it.

Per the HLS spec, we require a START-DATE for SCTE35-IN
However, unlike for SCTE35-OUT and SCTE35-CMD, it’s not clear what that value should be – and the HLS spec example does not include it.
@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Jan 8, 2025
@avelad avelad added this to the v4.13 milestone Jan 8, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit bc0e1c6 into shaka-project:main Jan 8, 2025
23 checks passed
@avelad avelad deleted the scte-35-start-date branch January 8, 2025 10:28
avelad added a commit that referenced this pull request Jan 10, 2025
…7841)

Per the HLS spec, we require a START-DATE for SCTE35-IN 
However, unlike for SCTE35-OUT and SCTE35-CMD, it’s not clear what that
value should be – and the HLS spec example does not include it.
avelad added a commit that referenced this pull request Jan 10, 2025
…7841)

Per the HLS spec, we require a START-DATE for SCTE35-IN 
However, unlike for SCTE35-OUT and SCTE35-CMD, it’s not clear what that
value should be – and the HLS spec example does not include it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants