Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tts:displayAlign on TTML #923

Closed
avelad opened this issue Jul 13, 2017 · 1 comment
Closed

Support tts:displayAlign on TTML #923

avelad opened this issue Jul 13, 2017 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@avelad
Copy link
Member

avelad commented Jul 13, 2017

Is possible add for support tts:displayAlign on TTML? This style is used for subtitle position.

Sample: https://shaka-player-demo.appspot.com/demo/#asset=https://irtdashreference-i.akamaihd.net/dash/live/901161/bfs/manifestARD.mpd;lang=es;play

Specification: https://www.w3.org/TR/ttaf1-dfxp/#style-attribute-displayAlign

@ismena ismena added the type: question A question from the community label Jul 13, 2017
@ismena
Copy link
Contributor

ismena commented Jul 13, 2017

That's a bit of a tricky question.
We use VTT cues to display text: https://w3c.github.io/webvtt/#vttcue and there is nothing in the interface that displayAlign could directly translate to. Looking at the doc I think we could arguably translate it to VttCue.positionAlign, but it's not supported by browsers at this point (hopefully it will be eventually), so it setting it will have no effect :(

We can still do it so it works once browsers implement it, but I'm afraid that's about the best we can do now.

On a related note: we're currently working on separating out text parsing and display logic so people can have custom text displayers, so I can make sure displayAlign is at least parsed if someone wants to use it in their custom display.

@joeyparrish joeyparrish added type: enhancement New feature or request and removed type: question A question from the community labels Jul 13, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Jul 13, 2017
@joeyparrish joeyparrish modified the milestones: v2.2.0, v2.3.0 Jul 14, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants