feat: init support for e2e libs with Playwright #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledEmaraDev
force-pushed
the
playwright-support
branch
from
54bc9af to
07908f2
Compare
grantspeelman
requested changes
May 29, 2023
alexeyr-ci
reviewed
May 30, 2023
Comment on lines
+21
to
+22
| /* Opt out of parallel tests on CI. */ | ||
| workers: process.env.CI ? 1 : undefined, |
There was a problem hiding this comment.
I believe this is a sensible default?
KhaledEmaraDev
force-pushed
the
playwright-support
branch
from
07908f2 to
00f86fa
Compare
alexeyr-ci
reviewed
May 31, 2023
Abstract Middleware logic from dependency on Cypress Add support for Playwright Signed-off-by: Khaled Emara <[email protected]>
Signed-off-by: Khaled Emara <[email protected]>
Signed-off-by: Khaled Emara <[email protected]>
KhaledEmaraDev
force-pushed
the
playwright-support
branch
2 times, most recently
from
f4c2c0b to
3f0afb2
Compare
Signed-off-by: Khaled Emara <[email protected]>
KhaledEmaraDev
force-pushed
the
playwright-support
branch
5 times, most recently
from
5e82375 to
67502f4
Compare
Signed-off-by: Khaled Emara <[email protected]>
KhaledEmaraDev
force-pushed
the
playwright-support
branch
from
67502f4 to
f48b84a
Compare
|
@grantspeelman @alexeyr-ci I think the PR is ready. It passes the CI for two envs but not the third for a weird reason. |
KhaledEmaraDev
force-pushed
the
playwright-support
branch
from
67b7cf2 to
d33d6bd
Compare
Co-authored-by: Grant Petersen-Speelman <[email protected]> Signed-off-by: Khaled Emara <[email protected]>
KhaledEmaraDev
force-pushed
the
playwright-support
branch
from
d33d6bd to
506f082
Compare
Signed-off-by: Khaled Emara <[email protected]>
Signed-off-by: Khaled Emara <[email protected]>
grantspeelman
approved these changes
Jun 22, 2023
|
Amazing, nice work @KhaledEmaraDev ! |
tvongaza
reviewed
Jun 22, 2023
| const appVcrEjectCassette = async () => { | ||
| const context = await contextPromise; | ||
|
|
||
| const response = await context.post("/__cypress__/vcr/eject"); |
There was a problem hiding this comment.
Should this be
const response = await context.post("/__e2e__/vcr/eject");
There was a problem hiding this comment.
You are right. Don't know how I missed it. Will create a PR for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116