Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware after load_config_initializers #62

Merged
merged 2 commits into from
May 28, 2020

Conversation

duytd
Copy link
Contributor

@duytd duytd commented May 27, 2020

This PR makes sure that middleware is added after CypressOnRails.configure is loaded. Now, use_middleware configuration option is not working. If the gem is not configured properly, there will be serious security issue.

See: https://guides.rubyonrails.org/configuring.html#initializers

@grantspeelman
Copy link
Collaborator

thanks @duytd
this should solve #57 as well.

@grantspeelman grantspeelman self-assigned this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants