Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in props as an object #227

Closed
justin808 opened this issue Feb 13, 2016 · 6 comments
Closed

Pass in props as an object #227

justin808 opened this issue Feb 13, 2016 · 6 comments

Comments

@justin808
Copy link
Member

We're passing in an array here as "props"
https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client%2Fapp%2Fbundles%2Fcomments%2Fstore%2FcommentsStore.js#L8

But props should be

{
comments: '<the comments array>'
}

This requires updating the jBuilder.

@jbhatab knows what to do on this one.

@alex35mil
Copy link
Member

👍

@marcelkooi
Copy link

This looks to be fixed by #246 correct?

@justin808
Copy link
Member Author

YES! Thanks for catching this!

@justin808
Copy link
Member Author

@Marz0 Let me know if you want a slack invite.

@marcelkooi
Copy link

@justin808 I'd be happy to join in on slack

@justin808
Copy link
Member Author

@Marz0 Please email me so I have your email!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants