diff --git a/CHANGELOG.md b/CHANGELOG.md index c3b670943..168cc4598 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,9 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com] Changes since last non-beta release. #### Fixed -- Changed i18n parsing to convert ruby i18n argument syntax into FormatJS argument syntax. by [sepehr500](https://github.com/sepehr500) +- Changed i18n parsing to convert ruby i18n argument syntax into FormatJS argument syntax. by [sepehr500](https://github.com/sepehr500) + +- Fixed an issue where the spec compiler check would fail if the project path contained spaces. [PR 1045](https://github.com/shakacode/react_on_rails/pull/1045) by [andrewmarkle](https://github.com/andrewmarkle) *Please add entries here for your pull requests that are not yet released.* diff --git a/lib/react_on_rails/utils.rb b/lib/react_on_rails/utils.rb index 61490f5f6..b9eb7dbd7 100644 --- a/lib/react_on_rails/utils.rb +++ b/lib/react_on_rails/utils.rb @@ -146,7 +146,7 @@ def required(arg_name) end def self.prepend_cd_node_modules_directory(cmd) - "cd #{ReactOnRails.configuration.node_modules_location} && #{cmd}" + "cd \"#{ReactOnRails.configuration.node_modules_location}\" && #{cmd}" end def self.source_path diff --git a/spec/react_on_rails/test_helper/webpack_assets_compiler_spec.rb b/spec/react_on_rails/test_helper/webpack_assets_compiler_spec.rb index 45cae174c..102f2fb75 100644 --- a/spec/react_on_rails/test_helper/webpack_assets_compiler_spec.rb +++ b/spec/react_on_rails/test_helper/webpack_assets_compiler_spec.rb @@ -24,7 +24,7 @@ expected_output = <<-MSG.strip_heredoc React on Rails FATAL ERROR! Error in building webpack assets! - cmd: cd #{Rails.root} && #{invalid_command} + cmd: cd \"#{Rails.root}\" && #{invalid_command} MSG expect do