Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @use along with @import #110

Closed
lucpotage opened this issue Jan 4, 2020 · 8 comments
Closed

Support @use along with @import #110

lucpotage opened this issue Jan 4, 2020 · 8 comments

Comments

@lucpotage
Copy link

I tried to use the loader with the latest sass version and unfortunately it does not seem to support @use and @forward rules.

This would be a nice addition.

@justin808
Copy link
Member

justin808 commented Jan 7, 2020

@lucpotage any chance that you can make a PR? Can you give me some doc links?

@lucpotage lucpotage changed the title Support @use and @forward syntax Support @use along with @import Jan 10, 2020
@lucpotage
Copy link
Author

Here is more info about the @use rule. Also, they discourage the use of @import the moment your start using the latest version of Sass.

So, I suppose this loader would become a v3 since it's a breaking change. We should clearly inform developers about it.

I will try to create a PR.

@lucpotage
Copy link
Author

I created a PR that I hope you will test. It needs extra work and I did not succeed in testing it properly. If you can, it would be great!

#111

@saltnpixels
Copy link

yes! I am looking for this as well

@justin808
Copy link
Member

justin808 commented Jun 14, 2020

@saltnpixels if you could submit a PR, I'd surely get it reviewed! Actually, we need to get #111 finished up!

@lucpotage
Copy link
Author

Seeing this conversation webpack-contrib/sass-loader#804, I suppose it's important to wait before starting anything with this loader.

In the meantime, I started to use postcss and realize I should have used it earlier. The ecosystem around the @use syntax is not mature. 😐

@justin808
Copy link
Member

@lucpotage see webpack-contrib/sass-loader#804 (comment)

Can you confirm that we've got the @use feature fixed?

@justin808
Copy link
Member

@saltnpixels, @lucpotage, @Tomburgs

Released version 2.1.0 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants