You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The recommended value for allowed_hosts is auto, not all which we have by default. It shouldn't be changed in a patch version, but maybe in 6.6.0 or 7.0.0?
https key on the Webpack side is deprecated in favor of server (which isn't currently supported on our side). Should we add support for it (even if we don't for other keys) and replace https in the default config?
The text was updated successfully, but these errors were encountered:
@justin808 I am working on this issue and I have some concerns.
I updated allowed_hosts and replaced https: false with server: http. These two changes are breaking ones, so the question is if we should provide backward compatibility? If yes, what is the best strategy?
I was also thinking if we could move this change to the next major release to reduce the number of breaking changes in version 7.
shakapacker/package/environments/development.js
Lines 17 to 41 in f5dfe4a
allowed_hosts
isauto
, notall
which we have by default. It shouldn't be changed in a patch version, but maybe in 6.6.0 or 7.0.0?https
key on the Webpack side is deprecated in favor ofserver
(which isn't currently supported on our side). Should we add support for it (even if we don't for other keys) and replacehttps
in the default config?The text was updated successfully, but these errors were encountered: