Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

feat: zrx support on bsc #1219

Merged
merged 31 commits into from
Mar 17, 2023
Merged

feat: zrx support on bsc #1219

merged 31 commits into from
Mar 17, 2023

Conversation

kaladinlight
Copy link
Contributor

  • add bsc to ZrxSwapper
  • new assetToToken helper function
  • general cleanup in surrounding area
  • remove .div(100) on slippage already passed as a decimal percent (resulted in failed quotes due to too small of slippage .002%)
  • add zrx parser to bsc in unchained-client and associated tests

@kaladinlight kaladinlight requested a review from a team as a code owner March 1, 2023 23:46
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, untested but conceptually looks good apart from a few terminology improvements

Base automatically changed from add-bsc to main March 14, 2023 20:45
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against the web PR, confirmed this does what it says on the box:

Input step

image

Confirm step

image

Status step

image

image

Noticed gas fees are slightly off (0.18 actual vs 0.27 expected) vs. the actual Tx ones, but that's neither a ZRX BSC nor a BSC specific concern

@gomesalexandre gomesalexandre merged commit e0e7b35 into main Mar 17, 2023
@gomesalexandre gomesalexandre deleted the bsc-zrx branch March 17, 2023 19:53
shapeshift-ci-bot pushed a commit that referenced this pull request Mar 17, 2023
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/asset-service-v8.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request Mar 17, 2023
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/swapper-v17.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request Mar 17, 2023
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/unchained-client-v10.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants