Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

BTC & ETH Sendmax refactor #249

Closed
0xdef1cafe opened this issue Nov 19, 2021 · 0 comments
Closed

BTC & ETH Sendmax refactor #249

0xdef1cafe opened this issue Nov 19, 2021 · 0 comments
Assignees
@elmutt

Comments

@0xdef1cafe
Copy link
Collaborator

0xdef1cafe commented Nov 19, 2021 •
edited by elmutt
Loading

Sendmax logic currently lives in web. It should live in each chain adapter and be different for each

  • Sending dust amounts of BTC shouldn't be allowed. Current sendmax logic was only built for eth. BTC needs to be based on sending all outputs minus the given fee (different coinselect calls)

  • Eth sendmax always defaults to assuming its a "fast" send to guarantee there is enough in the wallet. This isn't a good assumption and the eth logic may need to be changed as well
@elmutt elmutt self-assigned this Nov 19, 2021
@elmutt elmutt changed the title Sending dust amounts of BTC shouldn't be allowed BTC & ETH Sendmax refactor Nov 22, 2021
This was referenced Dec 1, 2021
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elmutt elmutt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elmutt @0xdef1cafe