Fix empty slug #1048
Merged
Fix empty slug #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
fix-empty-slug
branch
3 times, most recently
from
2df6a97 to
b106ba4
Compare
kpuputti
approved these changes
Mar 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A listing title that contained only stripped-off characters caused bugs in slug / pathName generation.
Longer version:
If a provider creates a listing with a title that only contains characters that we strip-off when creating a slug for URLs, It will cause an error and a blank page (or 500 if server rendered). (E.g. title like "--")
This can happen in search page too.