Hot fix replace '<' with unicode equivalent from script tag #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
hot-fix-replace-tag-starts-from-script-tag
branch
from
4c575fd to
dbe7583
Compare
|
Was highlighted to us (adventurent) by Nicolas Surribas (https://www.openbugbounty.org/researchers/devl00p/) via Open Bug Bounty. Thanks for applying the fix to the ftw-template! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix XSS-vulnerability on
SearchPagewhere URL param 'address' was exposed directly to schema, which is just a script tag:<script type="application/ld+json">. On server-side, this could leak malformed HTML through to browsers and made it possible to inject own script tags.However, CSP prevents any data breach: injected JS can't send data to unknonwn 3rd party sites.
NOTE: Check that
REACT_APP_CSPis in block mode on your production environment. You can read more from Flex Docs: https://www.sharetribe.com/docs/guides/how-to-set-up-csp-for-ftw/