Stripe create token for account #836
Conversation
Gnito
force-pushed
the
stripe-createToken-for-account
branch
from
81490c5 to
c787d02
Compare
|
One more thing coming: I'll move stripe.sdk call from PayoutPreferences.duck to user.duck. |
Gnito
force-pushed
the
stripe-createToken-for-account
branch
2 times, most recently
from
0fad40d to
c3b83a4
Compare
We are sending year, month, date triple to Stripe without converting it to timestamp
Gnito
force-pushed
the
stripe-createToken-for-account
branch
from
c4c3faa to
29b786e
Compare
| @@ -172,6 +173,12 @@ const PayoutDetailsFormComponent = props => ( | |||
| ); | |||
| } | |||
|
|
|||
| const stripeConnecteAccountTermsLink = ( | |||
There was a problem hiding this comment.
or is it s/Connecte/Connected?
src/translations/en.json
Outdated
| @@ -445,6 +445,8 @@ | |||
| "PayoutDetailsForm.streetAddressLabel": "Street address", | |||
| "PayoutDetailsForm.streetAddressPlaceholder": "Enter your street address…", | |||
| "PayoutDetailsForm.streetAddressRequired": "This field is required", | |||
| "PayoutDetailsForm.stripeConnecteAccountTermsLink": "Stripe Connected Account Agreement", | |||
| @@ -255,7 +255,7 @@ const PayoutDetailsFormComponent = props => ( | |||
| label={streetAddressLabel} | |||
| placeholder={streetAddressPlaceholder} | |||
| validate={streetAddressRequired} | |||
| onUnmount={() => change('streetAddress', undefined)} | |||
| onUnmount={() => form.change('streetAddress', undefined)} | |||
There was a problem hiding this comment.
Don't use deprecated 'change' but 'form.change' 1a0e9ae
Dropdown affects visible fields: this clears those fields.
CHANGELOG.md
Outdated
| @@ -12,10 +12,12 @@ way to update this template, but currently, we follow a pattern: | |||
|
|
|||
| ---- | |||
|
|
|||
| ## Upcoming version | |||
| ## v0.3.0 | |||
There was a problem hiding this comment.
Should we keep the Upcoming version here always until a release is made and with the release set the new version number? Then the changes would always be listed under the same captioon.
There was a problem hiding this comment.
The downside obviously is that we might forget if we've made some larger updates and accidentally do a minor version update when a major one would be in place. But I still find it more clear if the caption is always kept until a release comes.
There was a problem hiding this comment.
I was planning to make release immediately after this PR. Will do it in separate PR though - so, I'll pump this there.
CHANGELOG.md
Outdated
|
|
||
| * Remove custom touched handling from `FieldCheckboxGroup` as it has has become obsolete now that | ||
| Final Form is replacing Redux Form. [#837](https://github.com/sharetribe/flex-template-web/pull/837) | ||
| Final Form is replacing Redux Form. [#837](https://github.com/sharetribe/flex-template-web/pull/837) | ||
| * Create Stripe account directly instead of passing payoutdetails to Flex API (deprecated way). |
There was a problem hiding this comment.
s/payoutdetails/payout details
Gnito
force-pushed
the
stripe-createToken-for-account
branch
from
d07fbf5 to
db2c8f8
Compare
N.B. check this commit-by-commit