Fix obfuscate coordinates implementation #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Post review more than welcome |
kpuputti
reviewed
Sep 17, 2018
| @@ -12,6 +12,9 @@ way to update this template, but currently, we follow a pattern: | |||
|
|
|||
| --- | |||
| ## Upcoming version 2018-09-XX | |||
| * [fix] obfuscatedCoordinatesImpl didn't always return coordinates within given | |||
| offset radius. | |||
There was a problem hiding this comment.
Just a generic note on the abstraction level of this description: I think it is too detailed. Something like "Improved fuzzy location calculation" would probably suffice for people who read the changelog.
kpuputti
reviewed
Sep 17, 2018
| /** | ||
| * This obfuscatedCoordinatesImpl function is a temporary solution for the coordinate obfuscation. | ||
| * In the future, improved version needs to have protectedData working and | ||
| * available in accepted transaction. | ||
| * | ||
| * Based on: | ||
| * https://gis.stackexchange.com/questions/25877/generating-random-locations-nearby#answer-213898 |
There was a problem hiding this comment.
I truly wish we had better sources for reference than a random answer with three upvotes :/ But I hope you tested this well, no need to change if it works.
kpuputti
reviewed
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some coordinates were outside of given offset radius.