Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow head icon #951

Merged
merged 6 commits into from
Nov 14, 2018
Merged

Add arrow head icon #951

merged 6 commits into from
Nov 14, 2018

Conversation

OtterleyW
Copy link
Contributor

No description provided.

Copy link
Contributor

@lyyder lyyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one minor comment.

const classes = classNames(rootClassName || css.root, className);

const isRight = direction === DIRECTION_RIGHT;
const isleft = direction === DIRECTION_LEFT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l -> L for consistency: isLeft

@OtterleyW OtterleyW merged commit 0abb0f7 into master Nov 14, 2018
@OtterleyW OtterleyW deleted the addArrowHeadIcon branch November 14, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants