Add missing stripe countries #968

OtterleyW · 2018-12-05T10:52:11Z

Add Stripe support for new countries:

Canada
New Zealand
Switzerland
Norway
Hong Kong

Update also already existing countries to have all the required information:

Australia: address lines
United States: address lines and social security number

Note:

StripeBankAccountTokenInputField component and PayoutDetailsForm have some changes
Stripe related configuration is separated to new stripe-config.js file.
Multiple new translation keys were added and they might not be translated into French yet.

Check this commit for new translations keys added to fr.json translations file.

lyyder

Looks good 👍 , added one comment.

lyyder · 2018-12-07T09:48:39Z

src/components/StripeBankAccountTokenInputField/StripeBankAccountTokenInputField.util.js

@@ -117,7 +135,7 @@ export const translateStripeError = (country, intl, stripeError) => {
 *
 * @return {Object} key - value in Object literal.
 */
-export const mapInputsToStripeAccountKeys = (inputType, value) => {
+export const mapInputsToStripeAccountKeys = (country, values) => {


Remember to update the function doc ☝️

Gnito · 2018-12-07T12:16:15Z

src/forms/PayoutDetailsForm/PayoutDetailsAddress.js

+    })
+  );
+
+  const fields = (


Why not just return this? There's no need for a new variable.

Gnito

Looks good!
Just one comment to existing code, but add changes to fr.json too and update changelog.md.

Gnito · 2018-12-07T12:48:10Z

src/config.js

    accountConfig: {
      routingNumber: true,
      accountNumber: true,
    },
+    personalIdNumberRequired: true,


Try again with ssn_last_4: '0000'. Test environment might require it to be exactly that.
https://stripe.com/docs/connect/testing#test-personal-id-numbers

Gnito · 2018-12-10T08:58:09Z

src/forms/PayoutDetailsForm/PayoutDetailsForm.js

+
+      const personalIdNumberLabel = showPersonalIdNumber
+        ? intl.formatMessage({
+            id: `PayoutDetailsForm.personalIdNumberLabel.${country}`,


We have tried to avoid variables in translation keys. The reason is that most of our customers will have hard time finding correct components if they can't search full translation key from files. (We have used them only in situations where there is dynamic content coming from integrations - like Stripe errors.)

So, chained ternary or let should work better here.

Gnito · 2018-12-10T09:01:47Z

CHANGELOG.md

@@ -14,6 +14,9 @@ way to update this template, but currently, we follow a pattern:

 ## Upcoming version 2018-XX-XX

+* [add] Add Stripe support for new countries: Canada, New Zealand, Switzerland, Norway, and Hong Kong. 
+  Also add more required fields for US and Australia. There are multiple new translation keys that might not be translated into French yet. If you use French translation check PR for the changed keys. 
+  [#968](https://github.com/sharetribe/flex-template-web/pull/968)


yarn run format-docs

Gnito · 2018-12-10T09:15:48Z

src/stripe-config.js

+/*
+ * Stripe related configuration.
+ */
+


It might be best that we add more comments to this key. We have had a couple of problems when customizers haven't really understood that Stripe has a publishable key and private key - and they both should be set. So, repeating that info probably helps.

// NOTE: REACT_APP_STRIPE_PUBLISHABLE_KEY is mandatory environment variable. // This variable is set in a hidden file: .env // To make Stripe connection work, you also need to set Stripe's private key in the Flex Console.

…dd different bank account formats

Gnito

LGTM

OtterleyW added the in progress label Dec 5, 2018

OtterleyW force-pushed the add-missing-stripe-countries branch 2 times, most recently from 4194e5e to 6948113 Compare December 7, 2018 07:50

OtterleyW added review wanted and removed in progress labels Dec 7, 2018

OtterleyW requested review from Gnito and lyyder December 7, 2018 09:05

lyyder approved these changes Dec 7, 2018

View reviewed changes

lyyder reviewed Dec 7, 2018

View reviewed changes

OtterleyW temporarily deployed to sharetribe-starter-app December 7, 2018 12:14 Inactive

Gnito reviewed Dec 7, 2018

View reviewed changes

Gnito requested changes Dec 7, 2018

View reviewed changes

Gnito reviewed Dec 7, 2018

View reviewed changes

OtterleyW force-pushed the add-missing-stripe-countries branch 3 times, most recently from cafc8db to 4f5cbec Compare December 7, 2018 14:00

Gnito reviewed Dec 10, 2018

View reviewed changes

OtterleyW force-pushed the add-missing-stripe-countries branch from 4f5cbec to 708d423 Compare December 10, 2018 09:10

Gnito reviewed Dec 10, 2018

View reviewed changes

OtterleyW force-pushed the add-missing-stripe-countries branch 3 times, most recently from 20f081d to c78eac7 Compare December 10, 2018 11:53

OtterleyW added 7 commits December 10, 2018 14:50

Refactor mapInputsToStripeAccountKeys function to make it easier to a…

a84e8ae

…dd different bank account formats

Create PayoutDetailsAddress subcomponent and edit address config

89c6299

Add field for personal id number to PayoutDetailsForm

fe1082e

Add Stripe support for Canada

45e00d2

Add Stripe support for New Zealand

c79fb7e

Add Stripe support for Switzerland

d98d5d8

Add Stripe support for Norway

fe01020

OtterleyW added 5 commits December 10, 2018 14:50

Add Stripe support for Hong Kong

a137773

Add ID number field with validators to US and HK

0cc6cf9

Add ID number field with validators to US and HK

0035dae

Update translations

3707a1b

Move Stripe config to separate file

687cf7b

OtterleyW force-pushed the add-missing-stripe-countries branch from c78eac7 to abe628a Compare December 10, 2018 12:51

Gnito approved these changes Dec 11, 2018

View reviewed changes

Gnito added review ok and removed review wanted labels Dec 11, 2018

OtterleyW force-pushed the add-missing-stripe-countries branch 2 times, most recently from 72d73cc to 732fa86 Compare December 11, 2018 08:44

Update changelog

ffa3c7e

OtterleyW force-pushed the add-missing-stripe-countries branch from 732fa86 to ffa3c7e Compare December 11, 2018 08:46

OtterleyW merged commit 2625b44 into master Dec 11, 2018

OtterleyW deleted the add-missing-stripe-countries branch December 11, 2018 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing stripe countries #968

Add missing stripe countries #968

OtterleyW commented Dec 5, 2018 •

edited

Loading

lyyder left a comment

lyyder Dec 7, 2018

Gnito Dec 7, 2018

Gnito left a comment •

edited

Loading

Gnito Dec 7, 2018

Gnito Dec 10, 2018

Gnito Dec 10, 2018

Gnito Dec 10, 2018

Gnito left a comment

Add missing stripe countries #968

Add missing stripe countries #968

Conversation

OtterleyW commented Dec 5, 2018 • edited Loading

lyyder left a comment

Choose a reason for hiding this comment

lyyder Dec 7, 2018

Choose a reason for hiding this comment

Gnito Dec 7, 2018

Choose a reason for hiding this comment

Gnito left a comment • edited Loading

Choose a reason for hiding this comment

Gnito Dec 7, 2018

Choose a reason for hiding this comment

Gnito Dec 10, 2018

Choose a reason for hiding this comment

Gnito Dec 10, 2018

Choose a reason for hiding this comment

Gnito Dec 10, 2018

Choose a reason for hiding this comment

Gnito left a comment

Choose a reason for hiding this comment

OtterleyW commented Dec 5, 2018 •

edited

Loading

Gnito left a comment •

edited

Loading