Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FieldRadioButton component #977

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Create FieldRadioButton component #977

merged 3 commits into from
Dec 17, 2018

Conversation

OtterleyW
Copy link
Contributor

@OtterleyW OtterleyW commented Dec 11, 2018 •
edited
Loading

radiobutton-example

Gnito
Gnito reviewed Dec 17, 2018
View reviewed changes
src/components/FieldRadioButton/FieldRadioButton.css Outdated
width: 0;

/* Highlight the borders if the checkbox is hovered, focused or checked */
&:hover + label .box,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no checkboxes or .box classes.

Gnito
Gnito approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about unnecessary styles.

@OtterleyW OtterleyW force-pushed the create-radio-button-field branch from f20824e to db5487e Compare December 17, 2018 09:46
@OtterleyW OtterleyW force-pushed the create-radio-button-field branch from db5487e to a3f3417 Compare December 17, 2018 11:58
@OtterleyW OtterleyW merged commit e8c9863 into master Dec 17, 2018
@OtterleyW OtterleyW deleted the create-radio-button-field branch December 17, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Gnito approved these changes

Assignees
No one assigned
Labels
review comments review ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtterleyW @Gnito