Delete default builtin mail templates #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttiSalmivaara
force-pushed
the
delete-default-builtin-templates
branch
from
0bea253 to
c2e3260
Compare
ovan
reviewed
Dec 19, 2018
ext/default-mail-templates/README.md
Outdated
| This directory contains the default templates for all mails sent by default as result of activity in | ||
| the marketplace. | ||
| This directory contains the default templates for mails defined in the default transaction process. | ||
| Templates for other notifications can be edited in Console. |
There was a problem hiding this comment.
We could stick to same terminology that is used here: https://flex-docs.sharetribe.com/email-templates.html. So built-in emails and transaction emails.
anttiSalmivaara
force-pushed
the
delete-default-builtin-templates
branch
from
c2e3260 to
e353d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other mail templates than those related to transactions can now be edited in console, so they are removed from the repository. At the same time the context variables are updated to match console and README is updated.