Layout changes to listing and tx (enquiry) page #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lyyder
commented
Dec 27, 2018
lyyder
commented
- 3 baselines between the listing title and the Price per night on TX page (enquiry), it was 4.
- 8 baselines between the Price per night and the “Start date”, it was 10.
- 8 baselines between the Date’s line and the Booking breakdown, it was 9.
Apply design baseline definitions on BookingDatesForm, BookingPanel and ListingPage.
Gnito
reviewed
Dec 31, 2018
| @@ -89,6 +90,7 @@ const BookingPanel = props => { | |||
| : 'BookingPanel.perUnit'; | |||
|
|
|||
| const classes = classNames(rootClassName || css.root, className); | |||
| const titleClasses = classNames(css.bookingTitle, titleClassName); | |||
There was a problem hiding this comment.
This just creates a string
<h2 class="BookingPanel__bookingTitle_asdfasd TransactionPanel__bookingTitle_werwee">
Which means that both styles come from main.bundle.css and the import order might change the overriding rules.
maybe change this toclassNames(titleClassName || css.bookingTitle)
There was a problem hiding this comment.
Plus override all the style rules.
Fix the title class overriding so that the css load order does not affext the styles. Also removes a redundant media query definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.