Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lessopen feature causes tests to fail #2706

Open
tranzystorekk opened this issue Oct 11, 2023 · 3 comments
Open

lessopen feature causes tests to fail #2706

tranzystorekk opened this issue Oct 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@tranzystorekk
Copy link
Contributor

What steps will reproduce the bug?

N/A

What happens?

When attempting to build and test the bat pacakge for Void Linux with the lessopen feature enabled, the long_help and short_help tests fail, see CI logs: https://github.com/void-linux/void-packages/actions/runs/6487011019/job/17616392685

What did you expect to happen instead?

Tests run successfully.

How did you install bat?

N/A


bat version and environment

bat 0.24.0
Void Linux

@tranzystorekk tranzystorekk added the bug Something isn't working label Oct 11, 2023
@keith-hall
Copy link
Collaborator

thanks for reporting. I'm assuming that the LESSOPEN env var is non-empty in the Void Linux CI runner? Probably it makes sense for the integration tests to clear the LESSOPEN env var (except for the tests which already set it), as they likely assume it is blank except for those tests.

@tranzystorekk
Copy link
Contributor Author

Hm, I assumed it was a simple issue with those help output tests being hardcoded for the default-features case, where clap generates the --lessopen flag help conditionally.

@keith-hall
Copy link
Collaborator

Oh that would make more sense, somehow I didn't really understand the diff so skipped over that possibility. Thanks for reporting, it makes sense to get that fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants