Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature/Enhancement]: Allow to Choose NumPy/pandas for Group Aggregated Values #3

Closed
6 tasks done
ZenithClown opened this issue Apr 20, 2024 · 1 comment
Closed
6 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@ZenithClown
Copy link
Member

ZenithClown commented Apr 20, 2024

What is the New Feature/Enhancement?

To calculate percentile or quantile the module currently uses the pandas.Series.quantile method which works with the limited optional parameters {‘linear’, ‘lower’, ‘higher’, ‘midpoint’, ‘nearest’} (as on 20.04.2024). However, we can also choose np.quantile or np.percentile. This requires the following tweaks:

  • define argument to control module selection,
  • set the default behavior to pandas.Series.quantile method,
  • when choosing numpy set the default dropna = True as in pd.quantile,
  • allow to choose to drop null, or calculate using null with argument,
  • readability by updating documentations.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ZenithClown ZenithClown added the enhancement New feature or request label Apr 20, 2024
@ZenithClown ZenithClown self-assigned this Apr 20, 2024
@ZenithClown
Copy link
Member Author

Added arguments basemod and dropna to control the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant