Micro Blue Cod
High
The function generateOrderId here use keccak256 to generate a random and unique id for order. While the keccak256 of encoding sender and block.timestamp is not solid.
https://github.com/sherlock-audit/2024-11-oku/blob/main/oku-custom-order-types/contracts/automatedTrigger/AutomationMaster.sol#L90-L95 Here the function use keccak256(abi.encodePacked(sender, block.timestamp)) to generate id for order while this way can't guarantee the result is random and unique for this is a pseudo-random number. https://github.com/sherlock-audit/2024-11-oku/blob/main/oku-custom-order-types/contracts/automatedTrigger/Bracket.sol#L476-L493 The existingOrderId isn't solid. It can guarantee the new id is unique and it may affect the existed order with the same id.
No response
No response
No response
The existed order may be override and funds in it is lost.
No response
No response