083.md

Fierce Pecan Swallow

Medium

No zero address checks when setting in functions registerOracle and registerSubKeepers

Summary

Zero address missing check in AutomationMaster contract

This will be the main issue if oracle calls the function with zero address by mistake after the deployment. It can be reverted later but it will already do the damage.

If we call registerOracle(_tokens, _oracles) function and pass zero address in the first variable array. Then all oracles will get overridden and store under the first element of _tokens array

for (uint i = 0; i < _tokens.length; i++) {
            oracles[_tokens[i]] = _oracles[i];
        }

Root Cause

Before registering the oracles, do a zero address checks

https://github.com/sherlock-audit/2024-11-oku/blob/main/oku-custom-order-types/contracts/automatedTrigger/AutomationMaster.sol#L36

https://github.com/sherlock-audit/2024-11-oku/blob/main/oku-custom-order-types/contracts/automatedTrigger/AutomationMaster.sol#L47

Attack Path

There is no major attack path. The only thing is orders will lead to unexpected/ unseen behaviours in the protocol.

Impact

No Orders can be created and even if they are created it will not give correct token pricing until the owner updates these addresses

Mitigation

Use the require function before registering the oracles and tokens. Please do the same thing in other places wherever we are registering new addresses

 for (uint i = 0; i < _tokens.length; i++) {
require(_tokens[i] != 0x0 && _oracles[i] != 0x0, "zero address found");
            oracles[_tokens[i]] = _oracles[i];
        }