From f2c1e82e773dcedb3efcf35f7b71d8c7d5f936e6 Mon Sep 17 00:00:00 2001 From: shermp <14854761+shermp@users.noreply.github.com> Date: Sun, 28 Apr 2024 12:10:18 +1200 Subject: [PATCH] Set return type of Volume::save() to boolean --- src/ndb/NDBMetadata.cc | 4 ++-- src/ndb/NDBMetadata.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ndb/NDBMetadata.cc b/src/ndb/NDBMetadata.cc index bc07756..39f5e14 100644 --- a/src/ndb/NDBMetadata.cc +++ b/src/ndb/NDBMetadata.cc @@ -195,9 +195,9 @@ Result NDBMetadata::setMetadata(QString const& cID, QVariantMap md) { NDB_ASSERT(TypeError, validType, "Unexpected type for key %s", key.toUtf8().constData()); symbols.Volume__setAttribute(v, key, val); } - int res = symbols.Volume__save(v, device); + bool res = symbols.Volume__save(v, device); NDB_ASSERT(MetadataError, res, "error saving metadata for id %s", cID.toUtf8().constData()); - NDB_DEBUG("Volume__save returned with val %d", res); + NDB_DEBUG("Volume__save returned with val '%s'", res ? "true" : "false"); return Ok; } diff --git a/src/ndb/NDBMetadata.h b/src/ndb/NDBMetadata.h index 4586683..6319746 100644 --- a/src/ndb/NDBMetadata.h +++ b/src/ndb/NDBMetadata.h @@ -70,7 +70,7 @@ class NDBMetadata : public QObject { void (*VolumeManager__forEach)(QString const& dbName, std::function f); bool (*Volume__isValid)(Volume* _this); QVariantMap (*Volume__getDbValues)(Volume* volume); - int (*Volume__save)(Volume* _this, Device* device); + bool (*Volume__save)(Volume* _this, Device* device); void (*Volume__setAttribute)(Volume* _this, QString const& key, QVariant const& val); } symbols;