Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab should open popup right next to current tab #94

Closed
rugk opened this issue Aug 3, 2018 · 7 comments
Closed

New tab should open popup right next to current tab #94

rugk opened this issue Aug 3, 2018 · 7 comments

Comments

@rugk
Copy link

rugk commented Aug 3, 2018

Steps to reproduce

  1. Open a feed when setting is set to "opne in new tab"

Expected behavior

Just like "view source" opens to the right of the current tab.

Actual behavior

Opens at the end of tab list.

Screenshots and/or logs (see how to open the developer console in your browser)

See april/certainly-something#12 where another add-on had the same problem.

@happysurf
Copy link

happysurf commented Aug 3, 2018

Follow these steps:

  • Load about:config and digit the string browser.tabs.insertAfterCurrent in the search bar.
  • Set the preference to true by double-clicking on it.
  • Restart the browser.

@rugk
Copy link
Author

rugk commented Aug 3, 2018

Yes, but this affects all tabs. This is not wwhat I want.

See also the discussion under april/certainly-something#12 (comment):

I would like it to work like "View Page Source" and open a new tab to the immediate right of the current page

@shgysk8zer0
Copy link
Owner

I'll look into this. I'm not sure if I have any control.

If added, does a preference / checkbox defaulting to checked sound right? Or would it make more sense to add it to the <option>s of opening feeds?

@rugk
Copy link
Author

rugk commented Aug 3, 2018

Checkbox, but generally I don't need it be configurable- You also cannot configure View site source.

I'm not sure if I have any control.

Yes, you have: april/certainly-something@d8b6f0d

@rugk
Copy link
Author

rugk commented Aug 3, 2018

@Keith94 No, that should not change the browser settings. 😄 See commit linked above (why do I even link to solved issues already twice…? Two clicks and you see the solution.)

@shgysk8zer0
Copy link
Owner

@rugk Sometime people scan through issues without reading every comment in detail or opening every link. I haven't opened the link myself yet (I'm not in a position right now to go too in depth into anything, but I do have a few minutes), but I expect I'll find instructions on how to control tab position in there somewhere.

@shgysk8zer0
Copy link
Owner

@rugk There's now a "New tab" & "Adjacent tab" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants