Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twoslash node query blocks (^?) no longer display on separate lines since 0.x #688

Closed
3 of 5 tasks
mattpocock opened this issue May 31, 2024 · 0 comments · Fixed by #695
Closed
3 of 5 tasks

Twoslash node query blocks (^?) no longer display on separate lines since 0.x #688

mattpocock opened this issue May 31, 2024 · 0 comments · Fixed by #695

Comments

@mattpocock
Copy link

Validations

Describe the bug

In 0.*, twoslash node query blocks (^?) were shown on a separate line, like here in the TypeScript docs.

image

In 1.*, they are shown with position: absolute over the top:

image

This appears to be a deliberate change to the renderer.

I can see the use cases for this new absolute positioning. But for my use cases (screenshotting and docs) I need the query blocks to be shown on a separate line to the nodes they target. A config option to go back to the old behavior would be appreciated.

I can see that rendererClassic is available for me, so I'm using that now - but a separate option to preserve the separate-line queries would be good.

Reproduction

No reproduction required, since Anthony described this is a deliberate change

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants