Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo: grammer -> grammar #261

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix typo: grammer -> grammar #261

merged 1 commit into from
Nov 23, 2021

Conversation

samuela
Copy link
Contributor

@samuela samuela commented Nov 23, 2021

  • [n/a] This PR fixes #
  • [n/a] I have read docs for adding a language.
  • [n/a] I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • [n/a] I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

orta
orta reviewed Nov 23, 2021
View reviewed changes
packages/shiki/src/registry.ts
@@ -46,7 +46,7 @@ export class Registry extends TextMateRegistry {
return Object.keys(this._resolvedThemes) as Theme[]
}

public getGrammer(name: string) {
public getGrammar(name: string) {
return this._resolvedGrammars[name]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is public API, so we'd need a getGrammer -> getGrammar so that we don't need to bump the major. Otherwise looks 👍🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shiki is still 0.x

@orta
Copy link
Contributor

orta commented Nov 23, 2021

Yeah, this API doesn't really seem to be used outside of shiki from the look of the repos too

@orta orta merged commit 833711b into shikijs:main Nov 23, 2021
@samuela
Copy link
Contributor Author

samuela commented Nov 23, 2021

Thanks @orta and @Gerrit0 !

@samuela samuela deleted the samuela/grammer branch November 23, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta left review comments

@Gerrit0 Gerrit0 Gerrit0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuela @orta @Gerrit0