Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self.tags error in regenerator is wrong #1612

Closed
andyxning opened this issue May 4, 2015 · 2 comments · May be fixed by #1616
Closed

self.tags error in regenerator is wrong #1612

andyxning opened this issue May 4, 2015 · 2 comments · May be fixed by #1616

Comments

@andyxning
Copy link

it seems that the root reason is that the regenerator module has something wrong. Currently, i can tell that when we reload configuration, then the self.tags in Regenerator is wrong. It does not have anything to clean all previous tags count instead just adding.

        # Linkify tags
        for t in h.tags:
            if t not in self.tags:
                self.tags[t] = 0
            self.tags[t] += 1

this will cause all the tags count number increase every time we reload the configuration.

This will also make WebUI to present some error info.
and some related issues #1597
andyxning pushed a commit to andyxning/shinken that referenced this issue May 7, 2015
fix shinken-solutions#1612
fe388a1
andyxning pushed a commit to andyxning/shinken that referenced this issue May 7, 2015
fix shinken-solutions#1612
1ce0938
andyxning pushed a commit to andyxning/shinken that referenced this issue May 7, 2015
fix shinken-solutions#1612
d8c9be6
@andyxning andyxning mentioned this issue May 7, 2015
Open
@andyxning
Copy link
Author

I think i can give a method to fix this bug. see PR #1616.

However, with memory leak in WebUI, i have no idea and i think we should continue to work on it. :)

@naparuba
Copy link
Contributor

was merged if I'm not wrong, I fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1612 andyxning/shinken
2 participants
@naparuba @andyxning