Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run debounced modal opening positioning immediately #271

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Run debounced modal opening positioning immediately #271

merged 1 commit into from
Nov 7, 2018

Conversation

scottkidder
Copy link
Contributor

No description provided.

@scottkidder
Copy link
Contributor Author

This is required to get the modal overlays correctly positioned in our visual testing setup using ember-visual-test

@RobbieTheWagner
Copy link
Owner

@BrianSipple any reason we wouldn't want this? I don't know if it effects animations

@BrianSipple
Copy link
Contributor

I'm not seeing any adverse effects after running locally. LGTM 👍

@BrianSipple BrianSipple merged commit 5bde5ff into RobbieTheWagner:master Nov 7, 2018
@scottkidder
Copy link
Contributor Author

Thanks gents!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSipple BrianSipple Awaiting requested review from BrianSipple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottkidder @RobbieTheWagner @BrianSipple