Get Windows Processes Name Take Too Much Time

[huxt1993]

Describe the bug
It takes too much time to get the windows process name. In general, my windows has 260 processes, and When I get the names of these processes, it usually takes 8-9 seconds. It seems execute func getFromSnapProcess(pid int32) (int32, int32, string, error) 260*260 times, not 260 times.

To Reproduce

processInfos, _ := process.Processes()
for _, processInfo := range processInfos {
      name, _ := processInfo.Name()
}

Expected behavior
It should execute func getFromSnapProcess(pid int32) (int32, int32, string, error) 260 times and takse less than 1s

Environment (please complete the following information):

• Windows: Microsoft Windows [version 10.0.18363.1440]

Additional context
command: go build

C:\WINDOWS\system32>go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\xiaotao.hu\AppData\Local\go-build
set GOENV=C:\Users\xiaotao.hu\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\xiaotao.hu\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\xiaotao.hu\go
set GOPRIVATE=
set GOPROXY=https://goproxy.io
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=x86_64-w64-mingw32-gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\xiaotao.hu\AppData\Local\Temp\go-build909459346=/tmp/go-build -gno-record-gcc-switches

[Lomanic]

Which version of gopsutil are you using (which git tag or commit sha)?

I can't see how you can say that getFromSnapProcess is called 260*260 times in your example, it should be only called once per process here, so 260 times.

[huxt1993]

I'm very sorry for the number of calls getFromSnapProcess, it should be called 260times. And my psutils version is V3.20.10

[Lomanic]

Try running gopsutil/process benchmarks on the host with that many running processes, but I'm not sure we can do much here.

See also #468 (comment) or #609 with another benchmark using CreateToolhelp32Snapshot internally.