Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Shlink v2 together with v1 #174

Closed
5 tasks done
acelaya opened this issue Nov 24, 2019 · 0 comments · Fixed by #183
Closed
5 tasks done

Add support for Shlink v2 together with v1 #174

acelaya opened this issue Nov 24, 2019 · 0 comments · Fixed by #183
Labels
enhancement New feature or request
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Nov 24, 2019

  • On errors, try to get the error code from the type property, and fall back to the error property if not found.
  • On validation errors, try to get the list of invalidElements, and change the UI accordingly. (To be done on next release).
  • When the first request is performed on the API client, use v2 on the URL. If it returns a 404 and the content-type is not application/problem+json, transparently fall back to v1 and make any subsequent request to v1 too.
  • Make shlink-web-client take into consideration the fact that lat and long might be numbers and not strings. (already working like this)
  • Hide "preview" menu item if shlink version coming from health endpoint is 2.
@acelaya acelaya added the enhancement New feature or request label Nov 24, 2019
@acelaya acelaya added this to the 2.3.0 milestone Dec 14, 2019
@acelaya acelaya changed the title Add preliminary support for Shlink v2 together with v1 Add support for Shlink v2 together with v1 Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant