-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display visits in a table as a log #199
Comments
It definitely sounds like something nice to have 😀 |
Hey @Martinh0 Let me know what you think: https://youtu.be/Mii-CymZ9r8 Things still missing
|
Nice!! Are multiple selections possible? When you selected something ti is highlighted but does this also work if you select more then 1 item? But thats exactly what I wanted :D |
I guess it should be possible to allow multiple selection. As for the IP addresses, I'm afraid Shlink does not expose them, so it's not possible to display them here. |
Ofc the anonymized IPs like: not the real ones like: |
I know, but shlink does not expose them through API or CLI tool. |
I'm extracting mostly everything on first comment to a separate issue, to have smaller code additions. |
@Martinh0 this is how it looks with support for multiple selection: https://youtu.be/6lfJJ5q5oO4 The selection in the graphs is moved to a different issue, and some improvements on the selection will be done but for a future version. |
And done. I have just released v2.4.0, which is also available through https://app.shlink.io The feature is quite big, and I'm sure I missed some scenarios. Please, test it carefully and open new issues if you see any possible improvement or something does not work as expected. |
Why I asked for the IP is a simple reason. I life 50km from Stuttgart. 2 friends of mine life in Stuttgart direkt, some others 20-60km away. But all are getting shown as "Stuttgart" and as most people these days use Chrome and Windows there is NO WAY to differenciate them. But if I could see the (anonamized) IPs I could tell that these calls/visits are not comming from the same person. So if I have 20 visits for one link they all look the same. I can not tell which call is from the same recurring person. Maybe even setting a cookie would help to determinate a recurring visitor (if the same device is getting used) but as far as now they are not separatable. Do you understand what I mean? Also: if a issue/ticket here is closed GitHub does not notify me about mentions or new comments :P |
I'm not really confortable exposing the IP addresses by default in Shlink. Many things could go wrong if, for example, a bug is introduced on the anonymization and the original addresses end up being exposed. However, this is a fair point.
So, let's think on some solution, but let's move the conversation to Shlink, as the changes would need to be done there first shlinkio/shlink#725 |
Summary
Specially a more detailed "Log" below the chart would be good with the following informations:
2020.01.31
-01:54
Germany
-Stuttgart
(111.111.111.0
)Chrome (mobile)
-Windows
www.hotmann.de
2020.01.31
-01:54
Germany
-Stuttgart
(111.111.111.0
)Chrome (desktop)
-MacOS
github.com
---
---
----
(---
)---
----
---
---
---
----
(---
)---
----
---
---
---
----
(---
)---
----
---
---
---
----
(---
)---
----
---
... and so on..
Cuz now we cant see anything like this in the Frontend, just in the DB itself.
The text was updated successfully, but these errors were encountered: